web_programming/fridge_bites
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TIST-24: Fixed small issues on admin page #19

Merged
greendavid004 merged 2 commits from TIST-24 into develop 2025-06-29 13:43:48 +02:00
Conversation 4 Commits 2 Files Changed 8 +167 -50
greendavid004 commented 2025-06-29 12:35:07 +02:00
Owner
Copy Link
No description provided.
greendavid004 added 1 commit 2025-06-29 12:35:07 +02:00
steve_dekart reviewed 2025-06-29 12:35:45 +02:00
assets/css/admin.css Outdated
@ -22,6 +22,9 @@
}
body {
min-height: 100vh;
font-family: var(--common-font);
steve_dekart commented 2025-06-29 12:35:45 +02:00
Owner
Copy Link

This is not working because admin-header.php doesn't have Roboto Condensed font.

Replace old fonts to it:

<!-- Google fonts -->
    <link rel="preconnect" href="https://fonts.googleapis.com">
    <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
    <link
        href="https://fonts.googleapis.com/css2?family=Roboto+Condensed:ital,wght@0,100..900;1,100..900&family=Roboto+Slab:wght@100..900&display=swap"
        rel="stylesheet">
    <!-- Google fonts/ -->
    ```
This is not working because `admin-header.php` doesn't have `Roboto Condensed` font. Replace old fonts to it: ``` <!-- Google fonts --> <link rel="preconnect" href="https://fonts.googleapis.com"> <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> <link href="https://fonts.googleapis.com/css2?family=Roboto+Condensed:ital,wght@0,100..900;1,100..900&family=Roboto+Slab:wght@100..900&display=swap" rel="stylesheet"> <!-- Google fonts/ --> ```
greendavid004 marked this conversation as resolved
steve_dekart reviewed 2025-06-29 12:36:10 +02:00
assets/css/admin.css Outdated
@ -296,0 +305,4 @@
color: #6c757d;
}
.admin-single__form select{
steve_dekart commented 2025-06-29 12:36:10 +02:00
Owner
Copy Link

Why you add styles like input:disabled, select and etc in the admin.css like it can be used only on admin page?

Why you add styles like input:disabled, select and etc in the admin.css like it can be used only on admin page?
greendavid004 marked this conversation as resolved
steve_dekart reviewed 2025-06-29 12:36:23 +02:00
assets/css/admin.css Outdated
@ -296,0 +319,4 @@
margin-bottom: 20px;
}
.admin-single__form #instruction{
steve_dekart commented 2025-06-29 12:36:23 +02:00
Owner
Copy Link

Why do you use #id for textarea? And I don't see styles as on input.

Why do you use `#id` for textarea? And I don't see styles as on input.
greendavid004 marked this conversation as resolved
steve_dekart requested review from steve_dekart 2025-06-29 12:41:43 +02:00
greendavid004 added 1 commit 2025-06-29 13:24:23 +02:00
steve_dekart approved these changes 2025-06-29 13:41:44 +02:00
greendavid004 merged commit c35cf57eab into develop 2025-06-29 13:43:48 +02:00
greendavid004 deleted branch TIST-24 2025-06-29 13:43:49 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
steve_dekart
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
chole greendavid004 helena steve_dekart
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: web_programming/fridge_bites#19
No description provided.
Delete Branch "TIST-24"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?